fix: correctly identify imports with resolution-mode (#582) #595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used fix provided by @jer-sen
derdeka
reviewed
Aug 26, 2025
| @@ -9,7 +9,7 @@ export { Program, CompilerOptions, Symbol } from "typescript"; | |||
|
|
|||
| const vm = require("vm"); | |||
|
|
|||
| const REGEX_FILE_NAME_OR_SPACE = /(\bimport\(".*?"\)|".*?")\.| /g; | |||
| const REGEX_FILE_NAME_OR_SPACE = /(\bimport\(".*?"(, \{ assert: \{ "resolution-mode": "(import|require)" \} \})?\)|".*?")\.| /g; | |||
There was a problem hiding this comment.
Hi @FoxxMD,
thank you for pointing in the right direction. I had to use a different regex when using [email protected] and [email protected] with esm modules:
Suggested change
| const REGEX_FILE_NAME_OR_SPACE = /(\bimport\(".*?"(, \{ assert: \{ "resolution-mode": "(import|require)" \} \})?\)|".*?")\.| /g; | |
| const REGEX_FILE_NAME_OR_SPACE = /(\bimport\(.*?\)|".*?")\.| /g; |
I'm patching this line with the help of patch-package into typescript-json-schema to make it working again.
@YousefED Thank you for this great package! I would like to politely ask if this regular expression could be updated to work with ESM packages.
edit:
as just discovered @puckey suggests this change:
Suggested change
| const REGEX_FILE_NAME_OR_SPACE = /(\bimport\(".*?"(, \{ assert: \{ "resolution-mode": "(import|require)" \} \})?\)|".*?")\.| /g; | |
| const REGEX_FILE_NAME_OR_SPACE =/(\bimport\(".*?"(, [^)]+)?\)|".*?")\.| /g; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used fix provided by @jer-sen and closes #582
I believe this only occurs for ESM projects with
"moduleResolution": "NodeNext"intsconfig.jsonand introduced in TS 4.7. This fix is backwards compatible.